Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created filters with title and description for new course #1356

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Created filters with title and description for new course #1356

merged 8 commits into from
Nov 21, 2023

Conversation

mynotdoing
Copy link
Contributor

@mynotdoing mynotdoing commented Oct 26, 2023 •
edited
Loading

Created filters with title and description for new course

image

2023-10-26.18.10.12.mov

@mynotdoing mynotdoing self-assigned this Oct 26, 2023
@mynotdoing mynotdoing linked an issue Oct 26, 2023 that may be closed by this pull request
(SP:2) Create title, description, subject and level on MyCourses #1309
Closed
@mynotdoing mynotdoing requested a review from maarekua October 26, 2023 14:55
Tolik170
Tolik170 requested changes Oct 26, 2023
View reviewed changes
src/containers/my-courses/course-search-tool-bar/CourseCreateDescription.tsx Outdated Show resolved Hide resolved
src/containers/my-courses/course-search-tool-bar/CourseCreateDescription.tsx Outdated Show resolved Hide resolved
src/containers/my-courses/course-search-tool-bar/CourseSearchToolbar.style.ts Outdated Show resolved Hide resolved
src/containers/my-courses/course-search-tool-bar/CourseSearchToolbar.tsx Outdated Show resolved Hide resolved
src/containers/my-courses/course-search-tool-bar/CourseSearchToolbar.tsx Outdated Show resolved Hide resolved
src/pages/create-course/CreateCourse.tsx Outdated Show resolved Hide resolved
src/pages/create-course/CreateCourse.tsx Show resolved Hide resolved
src/pages/create-or-edit-lesson/CreateOrEditLesson.styles.ts Outdated Show resolved Hide resolved
src/pages/create-or-edit-lesson/CreateOrEditLesson.styles.ts Outdated Show resolved Hide resolved
src/containers/my-courses/course-search-tool-bar/CourseSearchToolbar.tsx Outdated Show resolved Hide resolved
@TSlashDreamy
Copy link
Contributor

You need to fix 2 code smells that SonarCloud found for you

@mynotdoing mynotdoing force-pushed the feature/1309/filters-in-create-course branch from b95438f to cbf1960 Compare October 27, 2023 08:02
@mynotdoing mynotdoing force-pushed the feature/1309/filters-in-create-course branch from 05ecd90 to 0d07b4c Compare October 31, 2023 21:48
abalanovsky
abalanovsky requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@abalanovsky abalanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that in the "Category" dropdown, those items that were selected by the teacher during registration should be displayed with a divider as a priority.

I do not see the implementation of this

Знімок екрана 2023-11-01 о 17 34 46

Same for subjects

Знімок екрана 2023-11-01 о 17 35 13

@mynotdoing mynotdoing force-pushed the feature/1309/filters-in-create-course branch from ee1af84 to ecb4394 Compare November 21, 2023 19:50
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@mynotdoing mynotdoing merged commit b5ac280 into develop Nov 21, 2023
4 checks passed
@mynotdoing mynotdoing deleted the feature/1309/filters-in-create-course branch November 21, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaAfonina MariaAfonina MariaAfonina left review comments

@Mav-Ivan Mav-Ivan Mav-Ivan approved these changes

@Tolik170 Tolik170 Tolik170 approved these changes

@dmtrth25 dmtrth25 dmtrth25 approved these changes

@TSlashDreamy TSlashDreamy TSlashDreamy approved these changes

@maarekua maarekua maarekua approved these changes

@OlyaKorchan OlyaKorchan Awaiting requested review from OlyaKorchan

@Marichka0406 Marichka0406 Awaiting requested review from Marichka0406

@abalanovsky abalanovsky Awaiting requested review from abalanovsky

Assignees

@mynotdoing mynotdoing

Labels
feature Frontend part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP:2) Create title, description, subject and level on MyCourses
8 participants
@mynotdoing @TSlashDreamy @maarekua @dmtrth25 @Tolik170 @MariaAfonina @abalanovsky @Mav-Ivan